Skip to content

Conversation

@younocode
Copy link
Contributor

No description provided.

@younocode younocode force-pushed the feat/users-account-name branch from 17f2b73 to 344730d Compare October 30, 2025 10:55
@younocode younocode added the preview This issue is already ready for preview label Oct 30, 2025
@github-actions
Copy link

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2067.sealoshzh.site

@younocode younocode force-pushed the feat/users-account-name branch from dc74c78 to b63ec87 Compare October 30, 2025 15:59
@github-actions
Copy link

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2067.sealoshzh.site

1 similar comment
@github-actions
Copy link

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2067.sealoshzh.site

@younocode younocode force-pushed the feat/users-account-name branch from 30c9658 to b042f5c Compare November 3, 2025 02:47
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2067.sealoshzh.site

3 similar comments
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2067.sealoshzh.site

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2067.sealoshzh.site

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2067.sealoshzh.site

@younocode younocode force-pushed the feat/users-account-name branch from 5831ceb to 606cec7 Compare November 4, 2025 04:15
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2067.sealoshzh.site

@younocode younocode force-pushed the feat/users-account-name branch from 606cec7 to 6a88471 Compare November 4, 2025 08:22
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2067.sealoshzh.site

@younocode younocode force-pushed the feat/users-account-name branch from fcd7b60 to 155ecfa Compare November 4, 2025 09:16
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2067.sealoshzh.site

1 similar comment
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2067.sealoshzh.site

@younocode younocode force-pushed the feat/users-account-name branch from 80abfda to 782a510 Compare November 4, 2025 15:31
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2067.sealoshzh.site

@younocode younocode force-pushed the feat/users-account-name branch from 782a510 to 457b6ca Compare November 5, 2025 02:24
@younocode younocode force-pushed the feat/users-account-name branch from 457b6ca to 9e349e9 Compare November 5, 2025 02:25
@younocode younocode requested a review from Copilot November 5, 2025 02:37
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2067.sealoshzh.site

1 similar comment
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2067.sealoshzh.site

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds account name functionality to the user system, allowing users to register and sign in with an account name as an alternative to email addresses. This includes database schema changes, API schema updates, backend validation logic, frontend UI changes, and internationalization updates.

  • Add accountName field to the User model with unique constraint and make email nullable
  • Implement account name-based registration and authentication with validation (min 3, max 30 chars, no '@' symbol)
  • Add admin setting to enable/disable account name registration
  • Update user creation flow to auto-generate unique account names when not provided

Reviewed Changes

Copilot reviewed 76 out of 76 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
packages/db-main-prisma/prisma/template.prisma Added accountName field (unique, nullable) and made email nullable in User model
packages/db-main-prisma/prisma//migrations/ Database migration scripts to add account_name column with data migration
packages/openapi/src/auth/*.ts Updated schemas for signup, signin, and user info to include accountName field
packages/core/src/utils/id-generator.ts Added generateAccountName() function for creating unique account identifiers
apps/nestjs-backend/src/features/user/user.service.ts Implemented account name validation, lookup, and auto-generation logic
apps/nestjs-backend/src/features/auth/local-auth/local-auth.service.ts Updated signup/signin flows to support account name authentication
apps/nextjs-app/src/features/auth/components/SignForm.tsx Added UI for account name input during registration and login
packages/common-i18n/src/locales/*/common.json Added translations for account name labels across all supported languages
apps/nestjs-backend/test/auth.e2e-spec.ts Added comprehensive test coverage for account name registration and signin

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@github-actions
Copy link

github-actions bot commented Nov 5, 2025

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2067.sealoshzh.site

@younocode younocode marked this pull request as draft November 5, 2025 05:25
@younocode younocode closed this Nov 5, 2025
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

🧹 Preview Environment Cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview This issue is already ready for preview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants