Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Image Preview #954

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

AliceLanniste
Copy link
Contributor

@AliceLanniste AliceLanniste commented Oct 1, 2024

close #767

tasks:

  • zoom in/out
  • rotate
  • reset
  • drag

@AliceLanniste
Copy link
Contributor Author

AliceLanniste commented Oct 10, 2024

@boris-w , I created a zoom in/out icon component, but it won't display in imagePreview. I don't know how to solve this problem and I don't understand the feature of image dragging, can you give me some help?

@boris-w
Copy link
Contributor

boris-w commented Oct 11, 2024

@boris-w , I created a zoom in/out icon component, but it won't display in imagePreview. I don't know how to solve this problem and I don't understand the feature of image dragging, can you give me some help?

Do you mean the imported icons don't show up?

@boris-w
Copy link
Contributor

boris-w commented Oct 11, 2024

Our icons are maintained on figma and synchronized to icons packages via scripts, give me a moment to think about how to collaborate on icon changes!

@AliceLanniste
Copy link
Contributor Author

Our icons are maintained on figma and synchronized to icons packages via scripts, give me a moment to think about how to collaborate on icon changes!

my icon components are copied from iconfont,so it doesn't show successful. I want to complete the pr, it is necessary to implement icon components

@boris-w
Copy link
Contributor

boris-w commented Oct 17, 2024

Today I'll update the icons you need to the develop branch, you just need to merge the develop.

@boris-w
Copy link
Contributor

boris-w commented Oct 17, 2024

Related: #996

@AliceLanniste
Copy link
Contributor Author

Today I'll update the icons you need to the develop branch, you just need to merge the develop.

thanks, could you add a reset icon component? , It's necessary to reset image for users

@boris-w
Copy link
Contributor

boris-w commented Oct 18, 2024

Today I'll update the icons you need to the develop branch, you just need to merge the develop.

thanks, could you add a reset icon component? , It's necessary to reset image for users

Reset -> RefreshCcw

@AliceLanniste
Copy link
Contributor Author

@boris-w ,could you explain about dragging ? I don't understand the functionality

@boris-w
Copy link
Contributor

boris-w commented Oct 23, 2024

@boris-w ,could you explain about dragging ? I don't understand the functionality

Dragging is considered for situations when the image is enlarged beyond the current screen size, requiring the ability to drag in order to view parts of the image that extend beyond the screen.

@AliceLanniste AliceLanniste marked this pull request as ready for review October 27, 2024 13:49
@AliceLanniste
Copy link
Contributor Author

@boris-w hello, I completed the pr ,can you review it?

@boris-w
Copy link
Contributor

boris-w commented Oct 29, 2024

It looks like you had a problem with the merge, a lot more unnecessary changes were made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Enhance Image Preview Capabilities in File Preview
2 participants