fix: populate ... for required modules
#693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Teal Playground URL: https://693--teal-playground-preview.netlify.app |
Instead of hardcoding the arguments within the loader, pass them through the searcher, as specified by the documented behavior: #689 (comment) > quoted from https://www.lua.org/manual/5.4/manual.html#pdf-require > >> Once a loader is found, require calls the loader with two arguments: >> modname and an extra value, a loader data, also returned by the >> searcher. The loader data can be any value useful to the module; >> for the default searchers, it indicates where the loader was found. >> (For instance, if the loader came from a file, this extra value is >> the file path.) Thanks @fperrad for the research!
This implements a compromise solution that allows Teal modules to always get both arguments, even in Lua 5.1 based systems (this should be harmless for modules which don't expect a second argument there), without hardcoding `loader_data`, just in case the user is on an environment that runs a patched `require` for debug reasons or something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #689.