Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very small changes for 1.20.1.
For the milk bottle change, the new implementation does make it that if one un-clearable status effect is targeted by the bottle, it simply won't clear any effects.
this is less than ideal, but the only alternative is to filter the list of active effects using that forge hook's push. implementing this would mean calling the hook multiple times, leading to the potential possibility of:
So that's why the current implementation is what it is. i hope it's acceptable--i still think it makes more sense than clearing that which should not be clearable