Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: ranking package #266

Merged
merged 4 commits into from
Apr 22, 2024
Merged

refactor: ranking package #266

merged 4 commits into from
Apr 22, 2024

Conversation

parksey
Copy link
Contributor

@parksey parksey commented Apr 22, 2024

πŸ“‹ Checklist

  • πŸ”€ PR 제λͺ©μ˜ ν˜•μ‹μ„ 잘 μž‘μ„±ν–ˆλ‚˜μš”? (e.g. feat: μœ μ € 쑰회 κΈ°λŠ₯ κ΅¬ν˜„)
  • 🏷️ 라벨, ν”„λ‘œμ νŠΈ, λ§ˆμΌμŠ€ν†€μ€ λ“±λ‘ν–ˆλ‚˜μš”?
  • 🧹 μ½”λ“œ μŠ€λ©œμ€ ν•΄κ²°ν–ˆλ‚˜μš”?

🧩 이슈 번호

πŸ‘©β€πŸ’» 곡유 포인트 및 λ…Όμ˜ 사항

@parksey parksey self-assigned this Apr 22, 2024
@parksey parksey added ♻️ refactor 기쑴의 μ½”λ“œ κ°œμ„  μž‘μ—… πŸ€ BE λ°±μ—”λ“œ λ ˆν¬μ§€ν† λ¦¬μ—μ„œμ˜ μž‘μ—… labels Apr 22, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
77.1% Coverage on New Code (required β‰₯ 80%)

See analysis details on SonarCloud

@parksey parksey merged commit a84265c into develop Apr 22, 2024
1 of 2 checks passed
@parksey parksey deleted the refactor/#265-ranking-package branch April 22, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@parksey parksey

Labels
πŸ€ BE λ°±μ—”λ“œ λ ˆν¬μ§€ν† λ¦¬μ—μ„œμ˜ μž‘μ—… ♻️ refactor 기쑴의 μ½”λ“œ κ°œμ„  μž‘μ—…
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

λž­ν‚Ή νŒ¨ν‚€μ§€ ꡬ쑰 λ¦¬νŒ©ν„°λ§
1 participant
@parksey