ENGDESK-33432: Create SWITCH_EVENT_SEND_INFO event #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baloeng
requested review from
Elhodred,
damirn,
dev-ryanc,
minhtuan1407-telnyx,
izzytelnyx and
tajamulTelnyx
Elhodred
approved these changes
Aug 14, 2024
dev-ryanc
reviewed
Aug 14, 2024
| @@ -2156,6 +2157,14 @@ static switch_status_t sofia_receive_message(switch_core_session_t *session, swi | |||
| TAG_END()); | |||
|
|
|||
| switch_safe_free(headers); | |||
|
|
|||
| if (switch_event_create(&event, SWITCH_EVENT_SEND_INFO) == SWITCH_STATUS_SUCCESS) { | |||
There was a problem hiding this comment.
Can we fire this in nua_r_info event instead?
There was a problem hiding this comment.
Good point - Since nua_r_info is triggered after receiving the 200 OK for the INFO message.
minhtuan1407-telnyx
approved these changes
Aug 28, 2024
| if (switch_event_create(&s_event, SWITCH_EVENT_SEND_INFO) == SWITCH_STATUS_SUCCESS) { | ||
| switch_channel_event_set_data(channel, s_event); | ||
| switch_event_add_header_string(s_event, SWITCH_STACK_BOTTOM, "message-indicate-info-event", "true"); | ||
| switch_event_add_header_string(s_event, SWITCH_STACK_BOTTOM, "content-type", switch_channel_get_variable(channel, "sip_info_content_type")); |
There was a problem hiding this comment.
@baloeng please correct the indentation here, rest looks good
There was a problem hiding this comment.
@tajamulTelnyx There's actually no indentation issue here. Just that the text was wrapped by github so it could fit to this page.
If you view the file as a whole, you wouldn't see this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.