Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEL-6122 Get rid of Poco thread pool #326

Open
wants to merge 6 commits into
base: telnyx/telephony/development
Choose a base branch
from
Open

TEL-6122 Get rid of Poco thread pool #326

wants to merge 6 commits into from

Conversation

damirn
Copy link

@damirn damirn commented Sep 12, 2024

… Get rid of static_casts.

dev-ryanc
dev-ryanc reviewed Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@dev-ryanc dev-ryanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, LGTM

src/include/Telnyx/UTL/Thread.h Outdated Show resolved Hide resolved
@damirn damirn changed the title TEL-6122 Do not keep a pointer to Poco::ThreadPool in a void* member.… TEL-6122 Get rid of Poco thread pool Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elhodred Elhodred Elhodred approved these changes

@dev-ryanc dev-ryanc dev-ryanc approved these changes

@baloeng baloeng baloeng approved these changes

@minhtuan1407-telnyx minhtuan1407-telnyx minhtuan1407-telnyx approved these changes

@izzytelnyx izzytelnyx Awaiting requested review from izzytelnyx

@tajamulTelnyx tajamulTelnyx Awaiting requested review from tajamulTelnyx

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@damirn @Elhodred @dev-ryanc @baloeng @minhtuan1407-telnyx