Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT/#443] Profile / 탈퇴 방지 팝업 추가 #444

Merged
merged 5 commits into from
Jun 7, 2024

Conversation

minju1459
Copy link
Contributor

⛳️ Work Description

  • 탈퇴 방지 팝업 구현
  • 친구 초대 > 추천친구 뷰 이동 후 친추 팝업
  • 탈퇴 방지 앰플리튜드 추가

📸 Screenshot

📢 To Reviewers

  • @team-yello/andro-d

@minju1459 minju1459 added FEAT ✨ 새로운 기능 구현 PULL REQUEST 🚀 pull reqeust 날리기 민주 🌳 Minju's Task labels Jun 6, 2024
@minju1459 minju1459 self-assigned this Jun 6, 2024
@minju1459 minju1459 requested a review from a team as a code owner June 6, 2024 18:26
@minju1459 minju1459 changed the title [FEAT] Profile / 탈퇴 방자 팝업 추가 [FEAT] Profile / 탈퇴 방지 팝업 추가 Jun 6, 2024
Copy link
Member

@Marchbreeze Marchbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿!

Comment on lines 87 to 88
val inviteFriendDialog = InviteFriendDialog.newInstance(viewModel.getYelloId(), "Previous Screen")
inviteFriendDialog.show(supportFragmentManager, INVITE_FRIEND_DIALOG)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 다이얼로그 초기값 null인 전역변수로 빼두고, 액티비티의 onDestroy에 =null로 해제해주는 로직 추가해주는게 좋을 것 같아용 ~

@minju1459 minju1459 merged commit 4454ded into develop Jun 7, 2024
1 check passed
@minju1459 minju1459 deleted the feat/#443-invite-friend-popup branch June 7, 2024 08:08
@minju1459 minju1459 changed the title [FEAT] Profile / 탈퇴 방지 팝업 추가 [FEAT/#443] Profile / 탈퇴 방지 팝업 추가 Jun 8, 2024
minju1459 added a commit that referenced this pull request Jun 9, 2024
[ADD/#445] 탈퇴 사유 이동 플로우 추가
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FEAT ✨ 새로운 기능 구현 PULL REQUEST 🚀 pull reqeust 날리기 민주 🌳 Minju's Task
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEAT] Profile / 탈퇴 방지 팝업 추가
2 participants