Add path provider for multi-platform support #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow turns out in the branching process it somehow didn't actually keep any of the bugfix commits I made. Edit: never mind the code is right I just forgot I never committed before that last commit |
|
@aidnem if you increment the upload-artifacts to v4 in this branch it'll pass CI and I'll approve |
|
@jkleiber done! |
jkleiber
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds environment handler and path provider so that you can use multiple sets of constants depending on what platform you're on
98% of this code is @avidraccoon 's but we had to make some last minute bug fixes, so this branch exists because the commit history diverged by accident during the bugfix process.
Closes #102 by updating to upload-artifacts v4