Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add photon vision #17

Merged
merged 8 commits into from
Sep 16, 2024
Merged

Add photon vision #17

merged 8 commits into from
Sep 16, 2024

Conversation

aidnem
Copy link
Contributor

@aidnem aidnem commented Sep 15, 2024

Adds basic photon vision implementation.

Works in sim, and has been demonstrated in HITL that a camera can output a pose estimate if all pose-rejection is disabled (this is as close to a proof of concept as we can get with only one camera).

Demonstration in sim can be seen in videos posted under #7

@aidnem aidnem linked an issue Sep 15, 2024 that may be closed by this pull request
3 tasks
@aidnem
Copy link
Contributor Author

aidnem commented Sep 16, 2024

@jkleiber In my opinion, the requirements of #7 were just a barebones system and should therefore be merged in now. Making vision really good can be done later, probably as part of #14

@aidnem aidnem requested a review from jkleiber September 16, 2024 01:42
Copy link
Member

@jkleiber jkleiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with 1 non blocking comment

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we gitignore this file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add it to my cleanup issue #18

@aidnem aidnem merged commit d50a8ec into main Sep 16, 2024
3 checks passed
@aidnem aidnem deleted the add-photon-vision branch September 16, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add photon vision
2 participants