Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update vendor libraries #241

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: update vendor libraries #241

wants to merge 1 commit into from

Conversation

pgund
Copy link

@pgund pgund commented Oct 20, 2024

just updated the vendor libraries so that the build doesn't fail

@admlvntv
Copy link
Contributor

What builds are failing? I’d rather not update dependencies until 2025 releases

Copy link
Contributor

@EQMoore EQMoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgund
Copy link
Author

pgund commented Oct 24, 2024

@admlvntv i think it was path planner lib that was failing, im not sure how important that is

@admlvntv
Copy link
Contributor

Can you just update that then?

@pgund
Copy link
Author

pgund commented Oct 24, 2024

uh, im not sure how to update an individual library; i just used the option to manage libraries and then updated them

@admlvntv
Copy link
Contributor

Revert your changes for every file except PathplannerLib.json. Each JSON file contains a different dependency that you updated. You can see the old and new version number for each in the commit history. The revert feature should be built into your IDE, if you can’t find it, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants