Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: new AppContext creator #9540

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

improve: new AppContext creator #9540

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 31 additions & 13 deletions scopes/harmony/application/app-context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,21 @@ import { Harmony } from '@teambit/harmony';
import { Component } from '@teambit/component';
import { Logger, LoggerAspect, LoggerMain } from '@teambit/logger';

export class AppContext extends ExecutionContext {
export interface AppContextOptions {
appName: string;
harmony: Harmony;
dev: boolean;
appComponent: Component;
workdir: string;
execContext: ExecutionContext;
hostRootDir?: string;
port?: number;
args?: string;
workspaceComponentPath?: string;
envVariables?: Record<string, string>;
};

export class AppContext extends ExecutionContext implements AppContextOptions {
constructor(
/**
* name of the app
Expand Down Expand Up @@ -85,19 +99,23 @@ export class AppContext extends ExecutionContext {
return this.harmony.get<T>(aspectId);
}

static compose(appContext: AppContext, overrides?: Partial<AppContext>) {
static fromOptions(appContext: AppContextOptions) {
return new AppContext(
overrides?.appName || appContext?.appName,
overrides?.harmony || appContext?.harmony,
overrides?.dev || appContext?.dev,
overrides?.appComponent || appContext?.appComponent,
overrides?.workdir || appContext?.workdir,
overrides?.execContext || appContext?.execContext,
overrides?.hostRootDir || appContext?.hostRootDir,
overrides?.port || appContext?.port,
overrides?.args || appContext?.args,
overrides?.workspaceComponentPath || appContext?.workspaceComponentPath,
overrides?.envVariables || appContext?.envVariables
appContext.appName,
appContext.harmony,
appContext.dev,
appContext.appComponent,
appContext.workdir,
appContext.execContext,
appContext.hostRootDir,
appContext.port,
appContext.args,
appContext.workspaceComponentPath,
appContext.envVariables
);
}

static compose(appContext: AppContextOptions, overrides?: Partial<AppContextOptions>) {
return AppContext.fromOptions({ ...appContext, ...overrides });
}
}