Skip to content

Commit

Permalink
enhance(webauthn): change default attestation mode
Browse files Browse the repository at this point in the history
* change default attestation mode from 'none' to 'direct' for better AAGUID handling in windows

Closes: #1381
  • Loading branch information
Stefan Jacobi committed Mar 27, 2024
1 parent 8ab246d commit a891b20
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions backend/handler/webauthn.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ func NewWebauthnHandler(cfg *config.Config, persister persistence.Persister, ses
RPDisplayName: cfg.Webauthn.RelyingParty.DisplayName,
RPID: cfg.Webauthn.RelyingParty.Id,
RPOrigins: cfg.Webauthn.RelyingParty.Origins,
AttestationPreference: protocol.PreferNoAttestation,
AttestationPreference: protocol.PreferDirectAttestation,
AuthenticatorSelection: protocol.AuthenticatorSelection{
RequireResidentKey: &f,
ResidentKey: protocol.ResidentKeyRequirementDiscouraged,
Expand Down Expand Up @@ -113,7 +113,7 @@ func (h *WebauthnHandler) BeginRegistration(c echo.Context) error {
ResidentKey: protocol.ResidentKeyRequirementRequired,
UserVerification: protocol.UserVerificationRequirement(h.cfg.Webauthn.UserVerification),
}),
webauthn.WithConveyancePreference(protocol.PreferNoAttestation),
webauthn.WithConveyancePreference(protocol.PreferDirectAttestation),
// don't set the excludeCredentials list, so an already registered device can be re-registered
)

Expand Down

0 comments on commit a891b20

Please sign in to comment.