Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guide on how to get user data #1028

Merged
merged 25 commits into from
Oct 11, 2023
Merged

Guide on how to get user data #1028

merged 25 commits into from
Oct 11, 2023

Conversation

Esther-Lita
Copy link
Contributor

Getting user data from token

@Esther-Lita Esther-Lita added the documentation Improvements or additions to documentation label Sep 26, 2023
@Esther-Lita Esther-Lita linked an issue Sep 26, 2023 that may be closed by this pull request
I specified that you can also get the user id on the frontend from "@teamhanko/hanko-elements" on the guide, before I was only referring to the email in this section

Commit Type: docs
@Esther-Lita Esther-Lita changed the title Started the guide to handle user data Guide on how to get user data Sep 27, 2023
Copy link
Contributor

@FreddyDevelop FreddyDevelop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code listings are for a specific language/framework which is not declared anywhere, so IMO it would be nice to have a selector like the one in the backend guide. So we can add more code listings for different languages/frameworks later.

docs/docs/guides/tutorials/userId.mdx Outdated Show resolved Hide resolved
docs/docs/guides/tutorials/userId.mdx Outdated Show resolved Hide resolved
docs/docs/guides/tutorials/userId.mdx Outdated Show resolved Hide resolved
docs/docs/guides/tutorials/userId.mdx Outdated Show resolved Hide resolved
docs/docs/guides/tutorials/userId.mdx Outdated Show resolved Hide resolved
docs/docs/guides/tutorials/userId.mdx Outdated Show resolved Hide resolved
docs/docs/guides/tutorials/userId.mdx Outdated Show resolved Hide resolved
docs/docs/guides/tutorials/userId.mdx Outdated Show resolved Hide resolved
docs/docs/guides/tutorials/userId.mdx Outdated Show resolved Hide resolved
docs/sidebars.js Outdated Show resolved Hide resolved
Esther-Lita and others added 11 commits September 27, 2023 10:51
"Data" to "data"
Commit Type: docs

Co-authored-by: Frederic Jahn <[email protected]>
Heading restructuring

Co-authored-by: Frederic Jahn <[email protected]>
Restructuring  intro to the guide
Commit Type: docs

Co-authored-by: Frederic Jahn <[email protected]>
Omitting information that could be too specific
Commit Type:docs

Co-authored-by: Frederic Jahn <[email protected]>
Suggesting the user where to use the function instead of specifying it
Commit Type: docs

Co-authored-by: Frederic Jahn <[email protected]>
The function should "return" the userData object instead of just log it
Commit Type:  docs

Co-authored-by: Frederic Jahn <[email protected]>
Renamed the file from "userId.mdx" to "userData.mdx"
Commit Type: docs

Co-authored-by: Frederic Jahn <[email protected]>
I separated the content depending on where the user data is needed, frontend or backend.
Added a selector specifying that the examples in this guide are Next.js related, also prepared it for adding other frameworks in the future

Commit Type: docs
docs/docs/guides/tutorials/userData.mdx Outdated Show resolved Hide resolved
docs/docs/guides/tutorials/userData.mdx Outdated Show resolved Hide resolved
docs/docs/guides/tutorials/userData.mdx Show resolved Hide resolved
docs/docs/guides/tutorials/userData.mdx Outdated Show resolved Hide resolved
docs/docs/guides/tutorials/userData.mdx Outdated Show resolved Hide resolved
docs/docs/guides/tutorials/userData.mdx Outdated Show resolved Hide resolved
docs/docs/guides/tutorials/userData.mdx Outdated Show resolved Hide resolved
docs/docs/guides/tutorials/userData.mdx Outdated Show resolved Hide resolved
docs/docs/guides/tutorials/userData.mdx Outdated Show resolved Hide resolved
Updated the function to get the user data using the Admin API to return properly the response.  Also updated the general text explaining the examples for better understanding of the users.

Commit Type: docs
@FlxMgdnz FlxMgdnz removed the request for review from lfleischmann October 11, 2023 10:24
@lfleischmann
Copy link
Member

lfleischmann commented Oct 11, 2023

@Esther-Lita,

could you resolve the merge conflict?

@FreddyDevelop,

theres still one "change requested" notice on this PR, has this bee addressed?

@Esther-Lita
Copy link
Contributor Author

@Esther-Lita,

could you resolve the merge conflict?

@FreddyDevelop,

theres still one "change requested" notice on this PR, has this bee addressed?

@lfleischmann there’s this issue with docs/sidebars.js on Docusaurus that I tried to look at but couldn’t really find a solution.

@Esther-Lita Esther-Lita dismissed FreddyDevelop’s stale review October 11, 2023 16:35

All requested changes fixed

@lfleischmann lfleischmann merged commit 0aa9aec into main Oct 11, 2023
12 checks passed
@lfleischmann lfleischmann deleted the handling-user-onboarding branch October 11, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add docs for handling new user onboarding in app that uses Hanko
5 participants