fix: set x-domain cookie lifetime to configured session lifetime #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cross-domain cookies set via
frontend-sdkhave aSessionmax-age/expiry instead of a lifetime according to the set session lifetime configured via Hanko Cloud Console/self-hosted config.Closes #1007
Implementation
Cookie max-age/expiry is calculated based of the
X-Session-Lifetimeheader.Tests
Because the
frontend-sdksets cookies only in a cross-domain scenario, you probably need a cross-domain setup of the applications.