Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: README.md #1123

Closed
wants to merge 7 commits into from
Closed

Conversation

PentesterPriyanshu
Copy link

@PentesterPriyanshu PentesterPriyanshu commented Oct 22, 2023

Added Twitter and Discord badges to the text to provide quick access to the Hanko community. The badges will enhance user experience and enable easy navigation to the community platforms.

Description

Added Twitter and Discord badges to the text to provide quick access to the Hanko community. The badges will enhance user experience and enable easy navigation to the community platforms.

Implementation

The badges were added directly to the existing text, utilizing Markdown syntax. The purpose is to make the community platforms easily accessible with a single click.

Tests

To verify the changes, follow these steps:

  1. Open the relevant page where the Hanko community text is located.
  2. Verify that the Twitter and Discord badges are visible and clickable.
  3. Confirm that clicking the badges redirects users to the respective Hanko community pages.

Todos

None.

Additional context

The addition of the badges aims to create an eye-catching and user-friendly experience, facilitating a seamless transition to the Hanko community platforms with just one click.
Screenshot from 2023-10-31 00-06-02
Screenshot from 2023-10-31 00-06-25

Added Twitter and Discord badges to the text to provide quick access to the Hanko community. The badges will enhance user experience and enable easy navigation to the community platforms.
@PentesterPriyanshu
Copy link
Author

@FlxMgdnz look at this changed readme.md i have added X badge with discord community badge also

@PentesterPriyanshu
Copy link
Author

@lfleischmann see this i have added badges of X and discord now people will easily go to our community because badges are eye catchy

@lfleischmann lfleischmann requested a review from FlxMgdnz October 26, 2023 11:00
@PentesterPriyanshu PentesterPriyanshu changed the title Update README.md Fix: README.md Oct 27, 2023
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@PentesterPriyanshu
Copy link
Author

@FlxMgdnz now review and merge it , thank you

@lfleischmann
Copy link
Member

@FlxMgdnz What's the status on this one? Looks like it can't be merged because there is still "1 change requested" by you. Do we still want this or can we close this?

@FlxMgdnz FlxMgdnz closed this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants