Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve(passkeys): improve passkey naming #1303

Merged
merged 5 commits into from
Jan 31, 2024

Conversation

shentschel
Copy link
Contributor

  • add cmd flag for loading aaguid-map file
  • add aaguid mapper for better passkey naming
  • bundle aaguid file in docker container
  • refactor file loading to reuse in multiple occasions

Closes: #1027

@FlxMgdnz FlxMgdnz requested a review from lfleischmann January 23, 2024 20:58
@lfleischmann
Copy link
Member

@shentschel The tests are failing.

backend/Dockerfile Show resolved Hide resolved
backend/mapper/aaguid_mapper.go Outdated Show resolved Hide resolved
deploy/docker-compose/quickstart.yaml Outdated Show resolved Hide resolved
backend/Dockerfile Outdated Show resolved Hide resolved
Stefan Jacobi added 4 commits January 29, 2024 09:43
* add cmd flag for loading aaguid-map file
* add aaguid mapper for better passkey naming
* bundle aaguid file in docker container
* refactor file loading to reuse in multiple occasions

Closes: #1027
@shentschel shentschel force-pushed the fix/1027-improve-passkey-naming branch from 96b0a30 to 5345d4c Compare January 29, 2024 10:17
@shentschel shentschel merged commit 409d09c into main Jan 31, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Improve passkey naming
2 participants