-
Notifications
You must be signed in to change notification settings - Fork 940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(thirdparty): add linkedin to social providers #1463
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adds linkedin to social providers via oidc Closes: #1452
shentschel
pushed a commit
to teamhanko/docs
that referenced
this pull request
May 16, 2024
* add guide for how to use linkedin as a third party provider. Related to: teamhanko/hanko#1463
lfleischmann
requested changes
May 28, 2024
Oh and can you regenerate the JSON schema? |
also rename provider to LinkedIn instead of Linkedin Related to: #1452
* also make linkedin optional and not required in json
The schema should now be up to date. |
Elements does not have a LinkedIn-Icon. (Sorry, I was sure I mentioned this yesterday already, but it looks like I forgot to actually post it 🙈) |
don't worry :) it should now be available |
lfleischmann
approved these changes
May 29, 2024
Ashutosh-Bhadauriya
pushed a commit
to teamhanko/docs
that referenced
this pull request
Jun 6, 2024
* feat(thirdparty): add linkedin provider docs * add guide for how to use linkedin as a third party provider. Related to: teamhanko/hanko#1463 * fix(guide): fix review issues * make `Create LinkedIn application` h2 * change `Microsoft` to `LinkedIn` * chore(linkedin): add warning for hanko cloud --------- Co-authored-by: Stefan Jacobi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement LinkedIn as social provider for third party logins
Closes: #1452
Implementation
implements linkedin third party provider. Uses OIDC to connect to linkedin as the old oauth connection is deprecated
Tests
Created a LinkedIn Test-Application with my linkedin account. After that I added client_id and secret to the config and tried to connect to linked in.
Todos
Create documentation in docs repo