Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(thirdparty): add linkedin to social providers #1463

Merged
merged 4 commits into from
May 29, 2024

Conversation

shentschel
Copy link
Contributor

Description

Implement LinkedIn as social provider for third party logins

Closes: #1452

Implementation

implements linkedin third party provider. Uses OIDC to connect to linkedin as the old oauth connection is deprecated

Tests

Created a LinkedIn Test-Application with my linkedin account. After that I added client_id and secret to the config and tried to connect to linked in.

Todos

Create documentation in docs repo

* adds linkedin to social providers via oidc

Closes: #1452
shentschel pushed a commit to teamhanko/docs that referenced this pull request May 16, 2024
* add guide for how to use linkedin as a third party provider.

Related to: teamhanko/hanko#1463
backend/config/config.go Outdated Show resolved Hide resolved
@lfleischmann
Copy link
Member

Oh and can you regenerate the JSON schema?

Stefan Jacobi added 2 commits May 29, 2024 09:18
also rename provider to LinkedIn instead of Linkedin

Related to: #1452
* also make linkedin optional and not required in json
@shentschel
Copy link
Contributor Author

The schema should now be up to date.

@shentschel shentschel requested a review from lfleischmann May 29, 2024 07:30
@lfleischmann
Copy link
Member

lfleischmann commented May 29, 2024

Elements does not have a LinkedIn-Icon.

(Sorry, I was sure I mentioned this yesterday already, but it looks like I forgot to actually post it 🙈)

@shentschel
Copy link
Contributor Author

don't worry :) it should now be available

@shentschel shentschel merged commit 3406fcf into main May 29, 2024
12 checks passed
Ashutosh-Bhadauriya pushed a commit to teamhanko/docs that referenced this pull request Jun 6, 2024
* feat(thirdparty): add linkedin provider docs

* add guide for how to use linkedin as a third party provider.

Related to: teamhanko/hanko#1463

* fix(guide): fix review issues

* make `Create LinkedIn application` h2
* change `Microsoft` to `LinkedIn`

* chore(linkedin): add warning for hanko cloud

---------

Co-authored-by: Stefan Jacobi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Sign in with LinkedIn
2 participants