feat(saml): make getting providers from metadata non-panic #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* show a warning if a provider cannot be fetched by its metadata url * skip the provider in provisioning state Closes: #1445
There was a problem hiding this comment.
Can we add information (e.g. domain or name) to the error message to identify the saml provider which is not working?
I got this error message while testing the PR, but when you have multiple identity provider it is hard/impossible to identify the provider which is not working: failed to initialize provider: unable to unmarshal idp metadata response body to xml: expected element type <EntityDescriptor> but have <html>
adds the idp config provider name to error message when the provider host cannot be parsed from metadata url or fetching metadata document fails. Closes: #1445
|
I extended the information with the idpconfig provider name. |
FreddyDevelop
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the error behaviour when initialising saml providers. Instead of stoping the application now there will be a warning that the provider could not be loaded. The provider in question will be ignored on startup.
Closes: #1445