Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base setup #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Base setup #1

wants to merge 1 commit into from

Conversation

tomfrew
Copy link

@tomfrew tomfrew commented Feb 10, 2024

A base setup that successfully runs the api and frontend images. Doesn't yet add the workers and PDF service.

This is by no means a final production ready setup, just sharing the update.

Changes in this PR

  • Creates S3 bucket with iam roles to access
  • Creates an additional security group that allows the API service to talk to network adaptor on port 3000 (separate to the app security group that allows http communication from the listener onwards)
  • Adjust the flow so the load balancers are created up front with the rest of the networking so we can pass both urls to each service
  • Removes the special characters in the random password generation as these where causing the URL parser some issues
  • Adds cloudwatch logging

These changes mess with the separation of concerns and ends up passing lots of values back and forth which is now a bit of a mess!

Sorry for the large diff, my formatter changed all the spacing and quotes and couldn't find a way to change it!

What's not done:

  • Region is hardcoded in a few places and should move to config
  • Worker service
  • PDF service
  • HTTPS setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant