Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meetings #739

Merged
merged 32 commits into from
Nov 23, 2023
Merged

Meetings #739

merged 32 commits into from
Nov 23, 2023

Conversation

Jdww
Copy link
Member

@Jdww Jdww commented Sep 26, 2023

No description provided.

@Jdww Jdww self-assigned this Sep 26, 2023
tiagobastos
tiagobastos previously approved these changes Sep 27, 2023
joaoinacio
joaoinacio previously approved these changes Sep 28, 2023
# Conflicts:
#	apiary.apib
#	src/changes-backwards-compatible.apib
@joaoinacio joaoinacio dismissed stale reviews from tiagobastos and themself via bb65621 October 17, 2023 09:30
joaoinacio
joaoinacio previously approved these changes Oct 17, 2023
tiagobastos
tiagobastos previously approved these changes Oct 18, 2023
@Jdww Jdww dismissed stale reviews from tiagobastos and joaoinacio via 5ea8063 October 18, 2023 14:51
@Jdww Jdww changed the title Meetings.complete Meetings Oct 18, 2023
tiagobastos
tiagobastos previously approved these changes Oct 18, 2023
@joaoinacio joaoinacio self-requested a review October 20, 2023 12:35
@adognameddog adognameddog removed their request for review November 17, 2023 08:16
@@ -3228,7 +3233,9 @@ Get a list of meetings.
+ Members
+ open
+ done

+ recurrence (object, nullable)
+ type: `recurrence` (string)
Copy link
Member

@mrtus mrtus Nov 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: We don't expose this resource anywhere yet, do we?

To which type refers this id then? Without exposing the resource I think we shouldn't include this property yet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: We don't expose this resource anywhere yet, do we?

To which type refers this id then? Without exposing the resource I think we shouldn't include this property yet.

🤔 Right. the goal is to be able to list recurring meetings from a recurrence id, so providing the recurrence (definition) isn't necessary for now.
We can omit the type property for now and provide just the id, which is the necessary info to have.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, where would that id then come from? From existing meetings which return the recurrence?

Though, I wouldn't really remove the type if we'd still expose the id.

mrtus
mrtus previously approved these changes Nov 22, 2023
gdegirmenci
gdegirmenci previously approved these changes Nov 22, 2023
@tiagobastos tiagobastos dismissed stale reviews from gdegirmenci and mrtus via 6ba2f43 November 22, 2023 15:12
@joaoinacio joaoinacio merged commit bdd29d3 into master Nov 23, 2023
1 check passed
@joaoinacio joaoinacio deleted the ATL-2280-meeting-complete branch November 23, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants