-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meetings #739
Meetings #739
Conversation
# Conflicts: # apiary.apib # src/changes-backwards-compatible.apib
and the missing customLocation id on locations.info response
ATL-2259 Meeting web hooks
@@ -3228,7 +3233,9 @@ Get a list of meetings. | |||
+ Members | |||
+ open | |||
+ done | |||
|
|||
+ recurrence (object, nullable) | |||
+ type: `recurrence` (string) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: We don't expose this resource anywhere yet, do we?
To which type refers this id then? Without exposing the resource I think we shouldn't include this property yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: We don't expose this resource anywhere yet, do we?
To which type refers this id then? Without exposing the resource I think we shouldn't include this property yet.
🤔 Right. the goal is to be able to list recurring meetings from a recurrence id, so providing the recurrence (definition) isn't necessary for now.
We can omit the type property for now and provide just the id, which is the necessary info to have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, where would that id then come from? From existing meetings which return the recurrence?
Though, I wouldn't really remove the type if we'd still expose the id.
No description provided.