Add Periodicity to quotation items on create, update and info #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmarfull-teamleader
requested review from
StijnVrolijk,
BrechtBonte,
mrtus,
JordyDeGroeve,
edwwaarrdd,
kensyc and
claude-cp
hmarfull-teamleader
requested review from
a team,
joaoinacio,
gehadMohamed,
StephenBeirlaen and
eniskraasniqi1
and removed request for
a team
BrechtBonte
reviewed
Jan 3, 2025
joaoinacio
approved these changes
Jan 6, 2025
gehadMohamed
approved these changes
Jan 6, 2025
StephenBeirlaen
approved these changes
Jan 6, 2025
BrechtBonte
approved these changes
Jan 6, 2025
tiagobastos
approved these changes
Jan 6, 2025
| @@ -105,7 +105,7 @@ Get a quotation | |||
| + tax_exclusive_before_discount (Money) | |||
| + tax_inclusive (Money) | |||
| + tax_inclusive_before_discount (Money) | |||
| + periodicity (Periodicity) | |||
| + periodicity (Periodicity, nullable) | |||
There was a problem hiding this comment.
Q: If I understood correctly .info will never be null, since it will be returned as "one_time_only"
There was a problem hiding this comment.
Q: If I understood correctly .info will never be null, since it will be returned as "one_time_only"
🤔 it is being returned as null, right? https://github.com/teamleadercrm/core/pull/40039/files#diff-d0cc69b0bbf026baf248d48ffc3962a248b9714e3bcde97b7ba6526276d6cf32R126
JordyDeGroeve
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Periodicity to quotation items on create, update and info using the existing Periodicity data structure.