Skip to content

PAC-950 Add compatibility with PHP 8.4 #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

PAC-950 Add compatibility with PHP 8.4 #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b9ef0d
PAC-950 Add compatibility with PHP 8.4
svizevv Sep 18, 2025
30f361e
PAC-950 Update dependencies
svizevv Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
# Version 26.1.0

## Features

### PHP 8.4 Compatibility

* Add PHP 8.4 support

# Version 26.0.2

## Bugfixes
Expand Down
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"license": "MIT",
"require": {
"php": "^8.1",
"techdivision/import-product": "^26.0.0"
"techdivision/import-product": "^26.2"
},
"require-dev": {
"doctrine/dbal": "^4.0.4",
Expand Down Expand Up @@ -40,4 +40,4 @@
]
}
}
}
}
6 changes: 3 additions & 3 deletions src/Observers/CleanUpLinkObserver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,11 @@ class CleanUpLinkObserver extends AbstractProductImportObserver implements Obser
*
* @param \TechDivision\Import\Product\Link\Services\ProductLinkProcessorInterface $productLinkProcessor The
* product link processor instance
* @param StateDetectorInterface|null $stateDetector The state detector instance to use
* @param StateDetectorInterface|null $stateDetector The state detector instance to use
*/
public function __construct(
ProductLinkProcessorInterface $productLinkProcessor,
StateDetectorInterface $stateDetector = null
?StateDetectorInterface $stateDetector = null
) {

// pass the state detector to the parent constructor
Expand Down Expand Up @@ -123,7 +123,7 @@ protected function process()
// prepare the links for the found link types and clean-up
foreach ($this->linkTypes as $linkTypeCode => $columns) {
// shift the column with the header information from the stack
list ($columnNameChildSkus, $callbackChildSkus) = array_shift($columns);
[$columnNameChildSkus, $callbackChildSkus] = array_shift($columns);

// query whether or not, we've up sell, cross sell or relation products
$links = $this->getValue($columnNameChildSkus, [], $callbackChildSkus);
Expand Down
Loading