Merge pull request #39 from techdivision/pac-5-optimize-code

Add a generic method for loading categories based on different values…
techdivision · Oct 16, 2023 · ce18b07 · ce18b07
2 parents 5a2f557 + 78c308d
commit ce18b07
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,9 @@
+# 25.0.4
+
+## Features
+
+* Add a generic method `getCategoryByValue` to load categories based on different values with serialized return.
+
 # 25.0.3
 
 ## Bugfixes

diff --git a/src/Observers/ProductUrlRewriteObserver.php b/src/Observers/ProductUrlRewriteObserver.php
@@ -120,7 +120,7 @@ protected function process()
 
             // remember the admin row on SKU to be safe on later process
             $this->adminRow[$sku] = array(
-                ColumnKeys::CATEGORIES       => $this->getValue(ColumnKeys::CATEGORIES),
+                ColumnKeys::CATEGORIES       => $this->getCategoryPath(),
                 ColumnKeys::PRODUCT_WEBSITES => $this->getValue(ColumnKeys::PRODUCT_WEBSITES),
                 ColumnKeys::VISIBILITY       => $this->getValue(ColumnKeys::VISIBILITY),
                 ColumnKeys::URL_KEY          => $this->getValue(ColumnKeys::URL_KEY)
@@ -362,4 +362,16 @@ protected function addArtefacts(array $artefacts)
     {
         $this->getSubject()->addArtefacts(ProductUrlRewriteObserver::ARTEFACT_TYPE, $artefacts);
     }
+
+    /**
+     * Generic method to load categories based on different values with serialized return.
+     *
+     * @param string $defaultValue The default value
+     *
+     * @return mixed|null
+     */
+    protected function getCategoryPath($defaultValue = null)
+    {
+        return $this->getValue($defaultValue);
+    }
 }