Com_hierarchy changes to check if user have sub users #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaivk369
reviewed
Jun 2, 2017
site/helpers/hierarchy.php
Outdated
| $HierarchyModelHierarchys->setState('filter.user_id', $user_Id); | ||
| $isManager = $HierarchyModelHierarchys->getItems(); | ||
|
|
||
| return $isManager; |
There was a problem hiding this comment.
this will retrun array and not boolean
There was a problem hiding this comment.
Actually, i have used this to retrieve users under the manager so can use in drop down filters. And if he has users under him then the user is the manager.
There was a problem hiding this comment.
Then change the function name.. getSubUsers
There was a problem hiding this comment.
You might need to check if the previous function name is used anywhere? If yes,you will need to change it to this new one
There was a problem hiding this comment.
what is the purpose of this helper ? Why are we adding more things to helpers instead of removing ? Cant you simply use the models for this ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.