Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug #82808 fix: On payment :- Uncaught TypeError. After conferming payment. #51

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion code/plugins/authorizenet/authorizenet/tmpl/default.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ function myValidate(f)
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this JS repeated in each layout ? It should be in a parent layout, and the sub-layouts should only have BS2/BS3 specific markup.

if (document.formvalidator.isValid(f))
{
f.check.value='<?php echo JSession::getFormToken(); ?>';
return true;
}
else
Expand Down Expand Up @@ -251,6 +250,7 @@ function plg_auth_showHide()
<input type="hidden" name="order_id" size="10" value="<?php echo $vars->order_id; ?>" />
<input type="hidden" name="plugin_payment_method" value="onsite" />
<input type="submit" name="submit" class="btn btn-success btn-large" value="<?php echo JText::_('SUBMIT');?>" />
<?php echo JHtml::_('form.token'); ?>
</div>
</div>
</form>
Expand Down
3 changes: 2 additions & 1 deletion code/plugins/authorizenet/authorizenet/tmpl/default_bs3.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
function myValidate(f)
{
if (document.formvalidator.isValid(f)) {
f.check.value='<?php echo JSession::getFormToken(); ?>';

return true;
}
else {
Expand Down Expand Up @@ -173,6 +173,7 @@ function plg_auth_showHide()
<input type="hidden" name="order_id" size="10" value="<?php echo $vars->order_id;?>" />
<input type="hidden" name="plugin_payment_method" value="onsite" />
<input type="submit" name="submit" class="btn btn-success btn-large" value="<?php echo JText::_('SUBMIT');?>" />
<?php echo JHtml::_('form.token'); ?>
</div>
</div>
</form>
Expand Down
3 changes: 1 addition & 2 deletions code/plugins/bycheck/bycheck/tmpl/default.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ function myValidate(f)
{
if (document.formvalidator.isValid(f))
{
f.check.value = '<?php echo JSession::getFormToken(); ?>';

return true;
}
else
Expand Down Expand Up @@ -82,6 +80,7 @@ function myValidate(f)
<input type="hidden" name="plugin_payment_method" value="onsite" />
<input type='submit' name='btn_check' id='btn_check' class="btn btn-success btn-large"
value="<?php echo JText::_('SUBMIT'); ?>">
<?php echo JHtml::_('form.token'); ?>
</div>
</form>
</div>
2 changes: 1 addition & 1 deletion code/plugins/bycheck/bycheck/tmpl/default_bs3.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ function myValidate(f)
{
if (document.formvalidator.isValid(f))
{
f.check.value = '<?php echo JSession::getFormToken(); ?>';
return true;
}
else
Expand Down Expand Up @@ -80,6 +79,7 @@ function myValidate(f)
<input type='hidden' name='return' value="<?php echo $vars->return;?>" >
<input type="hidden" name="plugin_payment_method" value="onsite" />
<input type='submit' name='btn_check' id='btn_check' class="btn btn-success" value="<?php echo JText::_('SUBMIT'); ?>">
<?php echo JHtml::_('form.token'); ?>
</div>
</div>
</form>
Expand Down
3 changes: 2 additions & 1 deletion code/plugins/byorder/byorder/tmpl/default.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
function myValidate(f)
{
if (document.formvalidator.isValid(f)) {
f.check.value='<?php echo JSession::getFormToken(); ?>';

return true;
}
else {
Expand Down Expand Up @@ -64,6 +64,7 @@ function myValidate(f)
<input type='hidden' name='return' value="<?php echo $vars->return;?>" >
<input type="hidden" name="plugin_payment_method" value="onsite" />
<input type='submit' name='btn_check' id='btn_check' class="btn btn-success btn-large" value="<?php echo JText::_('SUBMIT'); ?>">
<?php echo JHtml::_('form.token'); ?>
</div>

</div>
Expand Down
3 changes: 2 additions & 1 deletion code/plugins/byorder/byorder/tmpl/default_bs3.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
function myValidate(f)
{
if (document.formvalidator.isValid(f)) {
f.check.value='<?php echo JSession::getFormToken(); ?>';

return true;
}
else {
Expand Down Expand Up @@ -64,6 +64,7 @@ function myValidate(f)
<input type='hidden' name='return' value="<?php echo $vars->return;?>" >
<input type="hidden" name="plugin_payment_method" value="onsite" />
<input type='submit' name='btn_check' id='btn_check' class="btn btn-success btn-large" value="<?php echo JText::_('SUBMIT'); ?>">
<?php echo JHtml::_('form.token'); ?>
</div>

</div>
Expand Down