Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Archive #293

Closed
wants to merge 6 commits into from
Closed

Added Archive #293

wants to merge 6 commits into from

Conversation

hkbertoson
Copy link

I am not sure if this is what you were wanting. But I just added a new page called Archive and put the 2016 underneath that. This to resolve #292

Copy link
Contributor

@kacollins kacollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you also please add a line at the very bottom of the main site like on https://thunderplainsconf.com/ where it has Previous Years: 2022

@hkbertoson
Copy link
Author

Sure! Just a few

@travismiller travismiller self-requested a review October 26, 2023 20:08
Copy link
Member

@travismiller travismiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hkbertoson thanks for contributing!

I think if you don't include the package-lock.json change in your commit, the preview deploy will pass. There are probably some other changes that need to be included to change Node version and/or change dependencies. We would want to do that in a separate PR.

Thanks again!

Copy link
Contributor

@kacollins kacollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing the previous years in the footer. What we're looking to build up is something like this at the bottom of the main page:
image

@hkbertoson
Copy link
Author

I swear I addd them. Not sure what happened... Getting it fixed.

Copy link
Author

@hkbertoson hkbertoson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it updated!

@kacollins
Copy link
Contributor

This closes #292, #291, #290, #289, and #288

@maxxcrawford
Copy link
Member

@travismiller I know we've made changes for the 2023 site. Can we get this merged in?

@kacollins
Copy link
Contributor

Might just have to close this PR and get the Oklathon folks to add this to the footer in the current version of the site

@maxxcrawford
Copy link
Member

@kacollins Let's do that. I have a follow-up PR for the other site updates, and have left some commented code for where to put this.

@maxxcrawford
Copy link
Member

See #306 (This file in particular) for where to add the new links for 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants