ci(eslint): create workflow file for eslint #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bill ZHANG <[email protected]>
Signed-off-by: Bill ZHANG <[email protected]>
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Signed-off-by: Bill ZHANG <[email protected]>
Signed-off-by: Bill ZHANG <[email protected]>
resolve all the new errors but those in `ParameterComponents` Signed-off-by: Bill ZHANG <[email protected]>
Signed-off-by: Bill ZHANG <[email protected]>
Signed-off-by: Bill ZHANG <[email protected]>
Lutra-Fs
requested review from
kyubxy,
esterTion and
LorenzoValentine
and removed request for
esterTion
kyubxy
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESlint has been introduced to do the static checking during PR. This would provide an extra check other than the local
npm run lint. However, considering the GitHub Code Scanning Performance, it is still recommended that the contributors run the lint on their device.