Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ControlBar): implement redesigned control bar #165

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

refactor(ControlBar): implement redesigned control bar #165

wants to merge 7 commits into from

Conversation

ShaneHe023
Copy link
Collaborator

@ShaneHe023 ShaneHe023 commented Oct 7, 2023 •
edited by Lutra-Fs
Loading

Close #151

@Lutra-Fs
Copy link
Member

Lutra-Fs commented Oct 7, 2023

image

Lutra-Fs
Lutra-Fs reviewed Oct 7, 2023
View reviewed changes
Copy link
Member

@Lutra-Fs Lutra-Fs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say, restore/ save should be moved to another component. since they are not sharing location anymore

Lutra-Fs
Lutra-Fs requested changes Oct 7, 2023
View reviewed changes
Copy link
Member

@Lutra-Fs Lutra-Fs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Styling issue needs to be fixed.
Conflict needs to be resolved.
You are not using standard formatting. run npm run format to fix formatting issues (DO NOT push other files after running the command!)

@ShaneHe023
Copy link
Collaborator Author

I would say, restore/ save should be moved to another component. since they are not sharing location anymore

is it okay that I just set Ctrl bar above the Save/restore buttons for now?

@LorenzoValentine
Copy link
Member

I would say, restore/ save should be moved to another component. since they are not sharing location anymore

is it okay that I just set Ctrl bar above the Save/restore buttons for now?

What do you mean by 'Ctrl' bar? the Ctrl key in the keyboard?

@LorenzoValentine
Copy link
Member

above the Save/restore buttons for now

'above the Save/restore buttons for now' Do you think this is a good idea of fixing? Or you just want to make you fixing period shorter?

@Lutra-Fs Lutra-Fs force-pushed the main branch 2 times, most recently from 89bac3b to 0085d96 Compare October 9, 2023 12:17
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 10, 2023
View reviewed changes
src/components/ControlBar.tsx Fixed Show fixed Hide fixed
src/components/ControlBar.tsx Fixed Show fixed Hide fixed
@Lutra-Fs Lutra-Fs self-requested a review October 28, 2023 17:21
Lutra-Fs
Lutra-Fs requested changes Nov 13, 2023
View reviewed changes
src/components/ControlBar.tsx
@@ -41,6 +53,34 @@ export const RestoreBtn = styled(Button)`
}
`;

const ControlBarBtn = styled(Button)`
shape: circle;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shape is not in CSS properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lutra-Fs Lutra-Fs Lutra-Fs requested changes

@LorenzoValentine LorenzoValentine Awaiting requested review from LorenzoValentine

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement control bar redesigns
3 participants
@ShaneHe023 @Lutra-Fs @LorenzoValentine