feat: interpolation #214
Merged
feat: interpolation #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The output data type of the simulation component was changed to enhance the visual representation of the simulation. Initially, a simple Float32Array was used. However, a more complicated output data type - an array of Float32Arrays - was introduced to better represent the density data. We also added interpolation to handle low frame rates. This modification will provide a smoother simulation display. Furthermore, loggers were improved to provide more insights about the worker creation, frame rate, and the interpolation process. The naming of temporary variables holding crucial data was also refined for a better understanding of the codebase. Lastly, the code organization was improved and clearer comments were added. BREAKING CHANGE: Output from worker now distributes the data per second instead of per each run
the missing deps have been re-added to useEffect in Simulation.tsx according to ESLint Check
Changed the way cache is handled in the modelWorker file. Instead of duplicating the entire cache with the 'slice' method, the change uses the cache directly because the copy will automatically handled by postMessage. This optimization reduces unnecessary resource consumption and improves efficiency.
LorenzoValentine
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #153.
The interpolation has been added to the project. To implement it, the output density field will be packed into 1 array in worker per second and sent the data to the main thread for further processing. The interpolation now is a simple linear interpolation, where it only considers the generated frame inside the pack. In the implementation, the target is hardcoded as 30fps.
Some issues in the implementation
In this branch, if the user press pause button, the worker will pause after 1iteration, however, those iterations in that seconds will still be handled and returned for interpolation