Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(parameter-pane): implement the new parameter pane #82

Merged
merged 8 commits into from
Sep 17, 2023

ci(): merge `main` into `implemented-parameter-pane`

d345ca5
Select commit
Loading
Failed to load commit list.
Merged

refactor(parameter-pane): implement the new parameter pane #82

ci(): merge `main` into `implemented-parameter-pane`
d345ca5
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
GitHub Advanced Security / ESLint failed Sep 17, 2023 in 3s

16 new alerts including 16 errors

New alerts in code changed by this pull request

  • 16 errors

See annotations below for details.

View all branch alerts.

Annotations

Check failure on line 49 in src/components/ParameterComponents/ChoiceParameter.tsx

See this annotation in the file changed.

Code scanning / ESLint

Disallow unused expressions Error

Expected an assignment or function call and instead saw an expression.

Check failure on line 49 in src/components/ParameterComponents/ChoiceParameter.tsx

See this annotation in the file changed.

Code scanning / ESLint

Disallow comma operators Error

Unexpected use of comma operator.

Check failure on line 49 in src/components/ParameterComponents/ChoiceParameter.tsx

See this annotation in the file changed.

Code scanning / ESLint

Require expressions of type void to appear in statement position Error

Placing a void expression inside another expression is forbidden. Move it to its own statement instead.

Check failure on line 29 in src/components/ParameterComponents/DropdownParameter.tsx

See this annotation in the file changed.

Code scanning / ESLint

Disallow comma operators Error

Unexpected use of comma operator.

Check failure on line 29 in src/components/ParameterComponents/DropdownParameter.tsx

See this annotation in the file changed.

Code scanning / ESLint

Require expressions of type void to appear in statement position Error

Placing a void expression inside another expression is forbidden. Move it to its own statement instead.

Check failure on line 62 in src/components/ParameterComponents/SliderParameter.tsx

See this annotation in the file changed.

Code scanning / ESLint

Disallow unused expressions Error

Expected an assignment or function call and instead saw an expression.

Check failure on line 62 in src/components/ParameterComponents/SliderParameter.tsx

See this annotation in the file changed.

Code scanning / ESLint

Disallow comma operators Error

Unexpected use of comma operator.

Check failure on line 62 in src/components/ParameterComponents/SliderParameter.tsx

See this annotation in the file changed.

Code scanning / ESLint

Require expressions of type void to appear in statement position Error

Placing a void expression inside another expression is forbidden. Move it to its own statement instead.

Check failure on line 31 in src/components/ParameterComponents/ChoiceParameter.tsx

See this annotation in the file changed.

Code scanning / ESLint

Disallow certain types in boolean expressions Error

Unexpected nullable string value in conditional. Please handle the nullish/empty cases explicitly.

Check failure on line 15 in src/components/ParameterComponents/ParameterButton.tsx

See this annotation in the file changed.

Code scanning / ESLint

Require explicit return types on functions and class methods Error

Missing return type on function.

Check failure on line 70 in src/components/ParametersBar.tsx

See this annotation in the file changed.

Code scanning / ESLint

Require explicit return types on functions and class methods Error

Missing return type on function.

Check failure on line 78 in src/components/ParametersBar.tsx

See this annotation in the file changed.

Code scanning / ESLint

Require expressions of type void to appear in statement position Error

Returning a void expression from an arrow function shorthand is forbidden. Please add braces to the arrow function.

Check failure on line 119 in src/components/ParametersBar.tsx

See this annotation in the file changed.

Code scanning / ESLint

Require expressions of type void to appear in statement position Error

Returning a void expression from an arrow function shorthand is forbidden. Please add braces to the arrow function.

Check failure on line 125 in src/components/ParametersBar.tsx

See this annotation in the file changed.

Code scanning / ESLint

Require expressions of type void to appear in statement position Error

Returning a void expression from an arrow function shorthand is forbidden. Please add braces to the arrow function.

Check failure on line 136 in src/components/ParametersBar.tsx

See this annotation in the file changed.

Code scanning / ESLint

Require the use of `===` and `!==` Error

Expected '===' and instead saw '=='.

Check failure on line 141 in src/components/ParametersBar.tsx

See this annotation in the file changed.

Code scanning / ESLint

Require the use of `===` and `!==` Error

Expected '===' and instead saw '=='.