Skip to content

chore: avoid channel janitor if task is being moved by switchboarding [CHI-3353] #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gpaoloni
Copy link
Collaborator

@gpaoloni gpaoloni commented Jun 21, 2025

This PR is related to techmatters/flex-plugins#3089.

Description

This PR ensures that tasks that are canceled because of moving tasks between queues when switchboarding is enabled, do not trigger the "chat channel janitor". This is to avoid shutting down the channel, as it needs to be reused for the conversation after tasks are moved between queues.

Checklist

Verification steps

Refer to related PR.

AFTER YOU MERGE

  1. Cut a release tag using the GitHub workflow. Wait for it to complete and the notification to be posted in the #aselo-deploys Slack channel.
  2. Comment on the ticket with the release tag version AND any additional instructions required to configure an environment to test the changes.
  3. Only then move the ticket into the QA column in JIRA

You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P

@gpaoloni gpaoloni changed the title chore: avoid channel janitor if task is being moved by switchboarding chore: avoid channel janitor if task is being moved by switchboarding [CHI-3353] Jun 21, 2025
@gpaoloni gpaoloni marked this pull request as ready for review June 23, 2025 16:51
@gpaoloni gpaoloni requested a review from stephenhand June 23, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant