Skip to content

Fix: revised depth logic to handle custom depths #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jjmaynard
Copy link
Collaborator

@jjmaynard jjmaynard commented Jun 10, 2025

Description

PR addresses issue #251. Modifies depth handling logic to accept custom depth intervals. US 'rank_soils' function now requires the top and bottom depth measurements for each soil layer.

@jjmaynard jjmaynard changed the title Fix/revised depth logic to handle custom depths (#251) Fix/revised depth logic to handle custom depths Jun 10, 2025
@jjmaynard jjmaynard changed the title Fix/revised depth logic to handle custom depths Fix:revised depth logic to handle custom depths Jun 10, 2025
@jjmaynard jjmaynard changed the title Fix:revised depth logic to handle custom depths Fix: revised depth logic to handle custom depths Jun 10, 2025
-replaced horizonDepth with topDepth an bottomDepth.
Copy link
Member

@garobrik garobrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! this will break the backend so we'll need to handle that somewhere down the line once we merge this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants