V3 colorsets #116
Open
V3 colorsets #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the preset is configured early, there's no language context. This change ensures that the internal translate key gets a chance to be converted.
This should be enough to handle reinking, and offset for center draw positions
Turns any JSON schema (or a subpath of it) into a clean, customizable form with full diff changes and data management
Most of this should be removed :/
Needs work
Most we can do until it's time for print endpoint
Allows for custom markup within modal
This works, but doesn't properly manage state. Will be refactored as print job endpoint is built out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All work to get colorsets into the next working version (v3). Progress being tracked in #107