-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI #332
Fix CI #332
Conversation
This was done by running "pre-commit autoupdate --freeze".
Including them in the file would create the illusion that those were the versions actually used in CI, but they are not. The exact versions are determined by the pre-commit hooks which are pinned in .pre-commit-config.yaml.
Thank you @sleiner super close, just looks like a few lint rules! |
Yup - there are quite a few new ones now 😅 I'll fix these. |
Thank you! I think we'll want to update our github actions to also use python 3.11 instead of 3.10, right? https://github.com/techno-tim/k3s-ansible/blob/master/.github/workflows/test.yml#L17 https://github.com/techno-tim/k3s-ansible/blob/master/.github/workflows/lint.yml#L10 |
@sleiner what do you think? |
I'll follow up to this in a PR |
Thank you @sleiner !! |
* Update pre-commit actions This was done by running "pre-commit autoupdate --freeze". * Remove pre-commit only dependencies from requirements.in Including them in the file would create the illusion that those were the versions actually used in CI, but they are not. The exact versions are determined by the pre-commit hooks which are pinned in .pre-commit-config.yaml. * Ansible Lint: Fix role-name[path] * Ansible Lint: Fix name[play] * Ansible Lint: Fix key-order[task] * Ansible Lint: Fix jinja[spacing] * Ansible Lint: Fix no-free-form * Ansible Lint: Fix var-naming[no-reserved] * Ansible Lint: Fix yaml[comments] * Ansible Lint: Fix yaml[line-length] * Ansible Lint: Fix name[casing] * Ansible Lint: Fix no-changed-when * Ansible Lint: Fix fqcn[action] * Ansible Lint: Fix args[module] * Improve task naming
Proposed Changes
This was done by running
pre-commit autoupdate --freeze
.Including them in the file would create the illusion that those were the versions actually used in CI, but they are not.
The exact versions are determined by the pre-commit hooks which are pinned in
.pre-commit-config.yaml
.Checklist
site.yml
playbookreset.yml
playbook