Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sysctl tags #373

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Conversation

johnnyrun
Copy link
Contributor

Proposed Changes

pleae let me skip sysctl (advanced use)

Checklist

  • [ x] Tested locally
  • [x ] Ran site.yml playbook
  • Ran reset.yml playbook
  • Did not add any unnecessary changes
  • Ran pre-commit install at least once before committing
  • 🚀

@timothystewart6
Copy link
Contributor

Hi! Not sure what this change actually does and typically this should be configurable vs. hardcoded

@johnnyrun
Copy link
Contributor Author

Hi Tim.

Basically it does only tag the task and not changing the behaviour.
I would like this because I manage sysctl parameters on another role and my role and yours are conflicting on ipv6 sysctl setup (not mandatory for k3s).

Tagging the task permit me to use the "skip-tags" in parameter calling ansible-playbook and avoid forking this repo

@timothystewart6
Copy link
Contributor

timothystewart6 commented Oct 7, 2023

Thanks for the clarification! I think we should also add this too for consistency

- name: Set bridge-nf-call-iptables (just to be sure)

@timothystewart6
Copy link
Contributor

timothystewart6 commented Oct 7, 2023

After we add that additional tag to the prereqs, it's good to go!

@giannicarabelli
Copy link
Contributor

ops.. my fault. Pushed

@timothystewart6
Copy link
Contributor

Thank you!

@timothystewart6 timothystewart6 merged commit 38e7733 into techno-tim:master Oct 9, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants