Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all.yml #522

Closed
wants to merge 2 commits into from
Closed

Update all.yml #522

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f88e02b
Update all.yml
mrkhachaturov Jun 7, 2024
9cfb045
Update all.yml
mrkhachaturov Jun 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions inventory/sample/group_vars/all.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ system_timezone: "Your/Timezone"
# interface which will be used for flannel
flannel_iface: "eth0"

# interface which will be used for kube-vip
kube_vip_iface: "eth0"
Copy link
Contributor

@timothystewart6 timothystewart6 Jun 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should hardcode a default here. kube-vip will determine one on its own. I do think it would be nice to add it, but commented out. Something like:

# uncomment kube_vip_iface to override the default kube-vip interface
# kube_vip_iface: "eth0"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @timothystewart6. Sure, adding a comment will also be nice


# uncomment calico_iface to use tigera operator/calico cni instead of flannel https://docs.tigera.io/calico/latest/about
# calico_iface: "eth0"
calico_ebpf: false # use eBPF dataplane instead of iptables
Expand Down
Loading