Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade node to 20 to resolve deprecated warning #265

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Rindrics
Copy link

@Rindrics Rindrics commented Apr 9, 2024

Description: 概要

Resolve warnings below that occurs when technote-space/assign-author is being executed

Add assignee to PR
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: technote-space/assign-author@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Changes: 変更内容

  • Upgrade Node.js to 20 to resolve deprecated warning 0cc9d81
  • Upgrade Node.js on CI to follow project config 177424e

Expected Impact: 影響範囲

No bad impact will be introduced by this PR:
although upgrading runtime version may affects all functions that use version-specific functions, I confirmed yarn cover on Node.js 20.12.1 (specified in .node-version file)

Operating Requirements: 動作要件

Node.js 20.x.x

Additional context: 補足

GitHub says actions that they will start forcing JavaScript actions to use Node.js 20 from 13 May 2024.
c.f. https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Rindrics added 2 commits April 9, 2024 11:52
- to resolve warning below:
> Add assignee to PR
> Node.js 16 actions are deprecated. Please update the following actions
> to use Node.js 20: technote-space/assign-author@v1. For more
> information see:
> https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

- `yarn cover` succeeded on Node.js `20.12.1`
@Rindrics Rindrics requested a review from technote-space as a code owner April 9, 2024 03:17
Copy link

welcome bot commented Apr 9, 2024

🙌 Thanks for opening this pull request! Please check out our contributing guidelines.

@github-actions github-actions bot added the Type: CI/CD Introduces or updates CI/CD feature label Apr 9, 2024
@Rindrics Rindrics marked this pull request as draft April 9, 2024 03:20
@Rindrics
Copy link
Author

Rindrics commented Apr 9, 2024

I'll mark this PR as "ready" although workflow "Assign PullRequest to Project" failed
(because I can do nothing to resolve 401 error)

@Rindrics Rindrics marked this pull request as ready for review April 9, 2024 03:27
@massongit
Copy link

@technote-space I would like you to release this PR.
Is this PR review in progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: CI/CD Introduces or updates CI/CD feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants