-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FE Refinement (8 / ∞): html and body overflow settings + reactive app top bar to scrollbar #266
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This needs more work... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a list of niche things in order to develop the Dialog in #252 next.
Background
Current implementation only supports it to be fixed relative to the whole window. The reactive part of the AppTopBar monitors the value of
window.scrollTop
and decides its rendering. However, the AppTopBar needs to be a "fixed" element relative to arbitrary container, eg, fixed at the top within in a Dialog. So its scrolling monitoring mechanism must be able to monitor an arbitrary container rather than onlywindow
.Because of the rubber band scrolling effect in all Apple systems. On touch screens, if
html
contains another scrollable div, the scrollable div sometimes freezes because the gesture is conflicting to scroll the entirehtml
and thus freezes the scrollable div.rpreplay-final1679743484_Yw64vGx9.mp4
Changes
overflow-hidden
tohtml
, tells browser thathtml
is not scrollable so when gestures is scrolling something, it must not behtml
!body
scrollable because something must be scrollable...window.scrollTop
and the scroll position of an arbitrary containercontainerRef
, whichever has value provided, so it works with both with or without a container providedIt also fixes the behaviour of ATB unintentionally and it's lovely:
Screen.Recording.2023-03-25.at.6.01.48.AM.mov
Screen.Recording.2023-03-25.at.6.02.45.AM.mov