Autopost to new newsletter's mailchimp which has id 243735091b #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing Mailchimp API key most likely (don't have access to it)
rossPatton
suggested changes
Dec 21, 2020
|
|
||
| const mailchimp = new Mailchimp(process.env.MAILCHIMP_API_KEY); | ||
|
|
||
| module.exports.postToMailchimp = function(userInformation) { |
There was a problem hiding this comment.
entirely style related comment, feel free to ignore, but i think it's generally better to do something like:
const postToMailchimp = function(...) {
...
}
module.exports = {
postToMailchimp,
};
| }) | ||
| .catch(err => { | ||
| console.log('Error adding user to mailchimp') | ||
| console.log(params) |
There was a problem hiding this comment.
feel like we should probably use console.error here, and also is params defined?
| @@ -26,6 +27,9 @@ function signup(req, res, next) { | |||
| console.log(params); | |||
There was a problem hiding this comment.
looks like this was here already, but do we want to leave it? is it necessary i mean? typically logs like this should be removed before merging
kidmillions
approved these changes
Jan 14, 2021
|
I'll get the api key and add it to the heroku setup before we merge this. |
|
Hey @kidmillions -- are there any extra steps here for the mailchimp API key stuff? Do you need anything from me? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing Mailchimp API key most likely (don't have access to it)