Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: A few fixes #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

pa-jberanek
Copy link

Description

Removed dependency on yum and apt, they're not required. Added version into the Windows package resource, to stop repeated installations.

Issues Resolved

Stops repeated installation on each Chef run on Windows.

Check List

  • All tests pass.
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable

Removed dependency on yum and apt, they're not required.
Added version into the Windows package resource, to stop repeated installations.
@pa-jberanek
Copy link
Author

pa-jberanek commented Apr 23, 2024

Added a commit to fix 2 cookstyle issues.

Gemfile:14:3: W: Chef/Deprecations/FoodcriticTesting: The Foodcritic cookbook linter has been deprecated and should no longer be used for validating cookbooks. (https://docs.chef.io/workstation/cookstyle/chef_deprecations_foodcritictesting)
  gem 'foodcritic'
  ^^^^^^^^^^^^^^^^
test/integration/default/default_spec.rb:1:1: C: [Correctable] Style/Encoding: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8)
# encoding: utf-8
^^^^^^^^^^^^^^^^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant