fix: error handling for domainToASCII #1608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1608 +/- ##
==========================================
+ Coverage 79.00% 79.11% +0.10%
==========================================
Files 93 93
Lines 4878 4879 +1
Branches 937 937
==========================================
+ Hits 3854 3860 +6
+ Misses 718 711 -7
- Partials 306 308 +2 ☔ View full report in Codecov by Sentry. |
|
Hi @arthurschreiber, last time when we check this PR, you mentioned that description for this PR mentioned a test but it is missing from the changed files. I have went over the past commits, and I think we decided to remove the test since it seems the test is not needed. If you can give this PR a other look when you got time, see if we can merge this. |
MichaelSun90
changed the title
|
🎉 This PR is included in version 18.4.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
switch from punyCode to node:url introduce a behavior difference: #1597 (comment)
This fix the behavior.