Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Token Credential Support #1641

Merged
merged 3 commits into from
Jul 15, 2024
Merged

Conversation

arthurschreiber
Copy link
Collaborator

@arthurschreiber arthurschreiber commented Jul 2, 2024

This pull request contains the changes from #1624, plus the CI changes to run integration tests using the new token credential authentication type.

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 79.16%. Comparing base (3cd7e86) to head (bf61355).
Report is 1 commits behind head on master.

Files Patch % Lines
src/connection.ts 40.00% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1641      +/-   ##
==========================================
+ Coverage   78.42%   79.16%   +0.74%     
==========================================
  Files          93       93              
  Lines        4861     4871      +10     
  Branches      933      936       +3     
==========================================
+ Hits         3812     3856      +44     
+ Misses        752      711      -41     
- Partials      297      304       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arthurschreiber arthurschreiber changed the title Arthur/token credential support Token Credential Support Jul 4, 2024
@arthurschreiber arthurschreiber changed the title Token Credential Support feat: Token Credential Support Jul 4, 2024
@arthurschreiber arthurschreiber marked this pull request as ready for review July 15, 2024 10:22
@arthurschreiber arthurschreiber merged commit 3856dc5 into master Jul 15, 2024
20 of 25 checks passed
@arthurschreiber
Copy link
Collaborator Author

@elliot-huffman Thank you so much for providing the code changes for this. I merged this PR and it will be released soon-ish. I made sure to keep the attribution to the changes intact. 🙇‍♂️

Copy link

🎉 This PR is included in version 18.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants