-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ruff-format
for consistent code formatting
#240
base: main
Are you sure you want to change the base?
Conversation
80c0507
to
01aa1ae
Compare
Ok, all rebased, but I did not check the equivalence with |
@LecrisUT, what about syncing now the list of ignore rules with the |
Ruff config synced with the |
One more milestone bump (hopefully last), as we want to release today and so many code changes would not be a good idea right before the release. |
The docstring adjustments in #285 should be merged before this one. |
Signed-off-by: Cristian Le <[email protected]>
Let's make the setup of both projects consistent.
rev: "7.1.1" | ||
hooks: | ||
- id: flake8 | ||
- id: ruff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- id: ruff | |
- id: ruff-format |
Probably only want to deal with formatting as part of this PR?
- '--fix' | ||
- '--show-fixes' | ||
- id: ruff-format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- '--fix' | |
- '--show-fixes' | |
- id: ruff-format | |
- '--diff' |
[tool.ruff] | ||
line-length = 99 | ||
src = ["fmf", "tests"] | ||
target-version = "py39" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
99% sure ruff gets this from package metadata.
Depends-on #202 for the PEP621 of course
Copied all of the configuration from tmt and I have disabled a bunch of tests just so that we can bring this in first and then do each one in a separate PR