-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use hatch version
instead of packit default
#265
Conversation
By default packit creates rpms with version which can be older than packages already released in Fedora repositories. We need to use `hatch version` to at least bump the micro version.
@LecrisUT, could you please have a look? I tried latest Fedora:
Here's what
So, I guess we don't have another option. |
Hmm, interesting, this is because packit puts commit details in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Until packit/packit#2482 gets resolved, I think this would be a good workaround, but we would not be able to switch out of it until a next minor release because the predict next-version is bumping the patch version 1.4.2
and I am not sure how .dev10
orders compared to ^20241203
.
Another approach would be:
$ echo "$(git describe --abbrev=0 --tags)^$(date +%Y%m%d)"
1.4.1^20241203
Not sure how sh -c
and escapes must be done for this though
I just realized we need to obsolete the dropped |
Why would a workaround be needed? The update path should work fine:
|
The issue is when working on bug-fix versions like |
Yeah, I guess you're right:
That was the reason for
So this means, that development bug-fix versions appear to be newer then the final. But as we'll have separate |
By default packit creates rpms with version which can be older than packages already released in Fedora repositories. We need to use
hatch version
to at least bump the micro version.