Support beaker.pool hardware requirement for mrack (#3074)

Co-authored-by: Miloš Prchlík <[email protected]>
teemtee · Aug 1, 2024 · 5fbbd89 · 5fbbd89
1 parent 1e3c6fa
commit 5fbbd89
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 3 deletions.
diff --git a/docs/releases.rst b/docs/releases.rst
@@ -28,8 +28,8 @@ Change of Polarion field to store tmt id. Now using 'tmt ID' field,
 specifically created for this purpose instead of 'Test Case ID' field.
 
 The :ref:`/plugins/provision/beaker` provision plugin gains
-support for :ref:`cpu.vendor-name</spec/hardware/cpu>` hardware
-requirement.
+support for :ref:`cpu.vendor-name</spec/hardware/cpu>` and
+:ref:`beaker.pool</spec/hardware/beaker>` hardware requirements.
 
 
 tmt-1.34

diff --git a/spec/hardware/beaker.fmf b/spec/hardware/beaker.fmf
@@ -22,3 +22,6 @@ example:
     # Select any system, as long as it is not from the given Beaker pool
     beaker:
         pool: "!= very-rare-machines"
+
+link:
+  - implemented-by: /tmt/steps/provision/mrack.py
diff --git a/tests/unit/provision/mrack/test_hw.py b/tests/unit/provision/mrack/test_hw.py
@@ -53,7 +53,11 @@ def test_maximal_constraint(root_logger: Logger) -> None:
 
     assert result.to_mrack() == {
         'and': [
-            {'or': []},
+            {'pool': {
+                '_op': '!=',
+                '_value': 'foo.*',
+                },
+             },
             {'or': []},
             {
                 'and': [

diff --git a/tmt/steps/provision/mrack.py b/tmt/steps/provision/mrack.py
@@ -209,6 +209,19 @@ def _transform_unsupported(
     return MrackHWOrGroup()
 
 
+def _transform_beaker_pool(
+        constraint: tmt.hardware.TextConstraint,
+        logger: tmt.log.Logger) -> MrackBaseHWElement:
+    beaker_operator, actual_value, negate = operator_to_beaker_op(
+        constraint.operator,
+        constraint.value)
+
+    return MrackHWBinOp(
+        'pool',
+        beaker_operator,
+        actual_value)
+
+
 def _transform_cpu_flag(
         constraint: tmt.hardware.TextConstraint,
         logger: tmt.log.Logger) -> MrackBaseHWElement:
@@ -536,6 +549,7 @@ def _transform_system_numa_nodes(
     tmt.hardware.Constraint[Any], tmt.log.Logger], MrackBaseHWElement]
 
 _CONSTRAINT_TRANSFORMERS: Mapping[str, ConstraintTransformer] = {
+    'beaker.pool': _transform_beaker_pool,  # type: ignore[dict-item]
     'cpu.flag': _transform_cpu_flag,  # type: ignore[dict-item]
     'cpu.hyper_threading': _transform_cpu_hyper_threading,  # type: ignore[dict-item]
     'cpu.model': _transform_cpu_model,  # type: ignore[dict-item]