-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify the documentation building #2483
Conversation
d12585a
to
dba2609
Compare
dba2609
to
879adc4
Compare
I think it would be a nice addition. Or a similar tool. Having a spellchecker in play would be nice, to avoid typos and improve consistency (saying "html" at one place and "HTML" elsewhere..., or my classic "tmt" vs "Tmt" vs "TMT" :)
Ok, I'd vote to get rid of the apostrophes and be verbose, i.e. "we have" in the docs...
That we could improve by adding words to a list of allowed ones.
I'm not sure whether there are alternatives. Maybe it's also possible to use some integration with tools capable of checking not just spelling but also semantics ("it's" vs "its") and punctuation, like Grammarly (or ChatGPT :) But starting with at least a spellchecker would improve things. Edit: I'm playing a bit with the spelling builder, putting together a list of words to allow, and it doesn't look as bad as I expected. 80/20 in action, I guess, plus some really valid issues found, like "url" vs "URL", "yaml" where "YAML" should be, and some actual technical stuff like "httpd" or "beakerlib". I'll try to make a PR out of it, this looks like fun :) |
879adc4
to
15af051
Compare
15af051
to
7ecbb08
Compare
Ok, I've switched it to the combined Makefile+native sphinx format, and opened issues to track the rest. I've also factored out the other parts to dedicated PRs |
7ecbb08
to
cd2d4d2
Compare
/packit build |
cd2d4d2
to
c4ecb8b
Compare
@happz @lukaszachy This should also go into a milestone. Do we have anything more to discuss for this one? |
Works for me. Needs a rebase, but my local |
b05e5b6
to
0126eff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for preparing this, overall looks good, added just a few comments/questions.
/packit build |
e1741b8
to
62c9ee5
Compare
/packit build |
Btw, you can just edit a comment that has |
Nice. Thanks for the hint! |
62c9ee5
to
ad70de8
Compare
- Call `make generate` inside conf.py - Remove sphinx builder make targets Signed-off-by: Cristian Le <[email protected]><[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
It is covered by github action Signed-off-by: Cristian Le <[email protected]>
/packit build |
The two failures in |
Btw, |
* Simplify `docs/Makefile` * Fix pre-commit push branch target * Add doc-tests to GH-Actions * Remove `/plans/install/docs` Signed-off-by: Cristian Le <[email protected]>
docs/Makefile
to insideconf.py
to run automatically (reference: https://breathe.readthedocs.io/en/latest/readthedocs.html)Added more sphinx buildersMoved to individual PRs. See More sphinx builders #2487I've added these as GitHub Actions instead of pre-commits because:
tmt
itself