Support --workdir-root in the tmt clean command

[skycastlelily]

Pull Request Checklist

• implement the feature
• extend the test coverage
• include a release note

[skycastlelily]

Hi Petr, @psss, would you please spare some time to review this merge request,please? This is supposed to address #2807 , sorry for forgetting mentioned it before 1.36 release,and hope we can have this merged for 1.37: )

[martinhoyer]

lgtm. Just nitpicks.
I'm surprised setting a workdir root is so complicated tbh (not necessarily related to these changes). :)

[thrix]

@skycastlelily would it be possible to log the workdir root please in case the verbose mode is enabled please?

Something like:

❯ env | grep WORKDIR
TMT_WORKDIR_ROOT=/var/home/mvadkert/.local/share/tmt

❯ tmt clean -v
clean
    workdir /var/home/mvadkert/.local/share/tmt
guests
runs
images
    testcloud

[psss]

Looks good, just one nitpick. Also proposing a minore release note enhancement in 94b9098. @skycastlelily, does it look goot to you?

[psss]

@skycastlelily, what about extending /tests/clean/basic a bit to add at least a very basic coverage for the new option?

[skycastlelily]

does it look good to you?

Yeah:)

Is the new line really needed here?

I guess so, we need pass workdir_root to Status class,or, let's say,Common class, so that we can get self.workdir_root there:)

what about extending /tests/clean/basic a bit to add at least a very

basic coverage for the new option? Done,and updated:)

…

On Tue, Oct 22, 2024 at 6:01 PM Petr Šplíchal ***@***.***> wrote: ***@***.**** approved this pull request. Looks good, just one nitpick. Also proposing a minore release note enhancement in 94b9098 <94b9098>. @skycastlelily <https://github.com/skycastlelily>, does it look goot to you? ------------------------------ In tmt/cli.py <#2850 (comment)>: > raise tmt.utils.GeneralError(f"Path '{workdir_root}' doesn't exist.") status_obj = tmt.Status( - logger=context.obj.logger.clone().apply_verbosity_options(**kwargs), - cli_invocation=CliInvocation.from_context(context)) + logger=context.obj.logger.clone(). + apply_verbosity_options(**kwargs), Is the new line really needed here? — Reply to this email directly, view it on GitHub <#2850 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKFR23AVZCNZZ24VWLUPEZTZ4YPAPAVCNFSM6AAAAABGDUNQC6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGOBUGY2DMNZSGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[martinhoyer]

@psss with the test added, perhaps this can get the ready-to-merge label back?