Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add install prepare plugin using install into tmt try #3071

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Add install prepare plugin using install into tmt try #3071

wants to merge 15 commits into from

Conversation

falconizmi
Copy link
Collaborator

@falconizmi falconizmi commented Jul 2, 2024 •
edited
Loading

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • adjust plugin docstring
  • mention the version
  • include a release note

@falconizmi falconizmi changed the title Iquwarah tmt try package Add package prepare plugin using install into tmt try Jul 2, 2024
@falconizmi falconizmi added step | prepare Stuff related to the prepare step command | try tmt try command labels Jul 2, 2024
@lukaszachy
Copy link
Collaborator

Isn't it more natural to call that option install? As in tmt try --install zsh fedora@container....

@falconizmi falconizmi assigned falconizmi and unassigned falconizmi Jul 10, 2024
@falconizmi falconizmi changed the title Add package prepare plugin using install into tmt try Add install prepare plugin using install into tmt try Jul 11, 2024
@falconizmi falconizmi added the ci | full test Pull request is ready for the full test execution label Jul 11, 2024
@falconizmi falconizmi force-pushed the iquwarah-tmt-try-epel branch 2 times, most recently from c2806be to 9ea8e3b Compare July 29, 2024 14:37
@happz happz added this to the 1.36 milestone Jul 31, 2024
@happz happz modified the milestones: 1.36, 1.37 Sep 3, 2024
happz
happz requested changes Sep 16, 2024
View reviewed changes
docs/releases.rst Outdated
@@ -84,6 +84,9 @@ the ``clean`` subcommand. Users can clean resources from the last
run or from a run with a given id. Users can also choose to skip
cleaning ``guests``, ``runs`` or ``images``.

``tmt try`` now supports :ref:`/stories/cli/try/option/install` option
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be moved to the right release.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it? I see it in 1.35.0 release section, shouldn't it be in the upcoming one, 1.37.0?

Copy link
Collaborator Author

@falconizmi falconizmi Sep 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I believe that I changed that .. maybe due some rebase from other branch or change in format of release section it went back to 1.35 .. for now its fixed

stories/cli/try.fmf Outdated Show resolved Hide resolved
@falconizmi falconizmi force-pushed the iquwarah-tmt-try-epel branch 3 times, most recently from 66a661a to 241dda6 Compare September 16, 2024 14:11
@falconizmi
Copy link
Collaborator Author

/packit build

@falconizmi
Copy link
Collaborator Author

/packit build

Base automatically changed from iquwarah-tmt-try-epel to main September 24, 2024 13:43
Ismail Ibrahim Quwarah and others added 15 commits September 24, 2024 15:50
Add epel prepare plugin using feature
5ec62eb 
fix handle options in tmt try

Drop unnecessary prepare- from phase name
Add epel release note in tmt try
b365f02 
fix `epel` release note in tmt try

Add mention of prepare/feature plugin in tmt try release notes

Adjust text length to match the header

Fix links to plugins (#3104)

Add missing full stop
Move release note to 1.37
5227dab
@psss
Simplify the implementation a bit
7969566 
The extra action for handling options should not be needed.
Plus it breaks use cases like `tmt try --epel` with tests.
Included a few minor style adjustments.
Add package prepare plugin using install in tmt try
2401a81 
Drop unnecessary prepare- from phase name
Add package coverage test in tmt try
3856840
Add package documentation in tmt try
ce4c443
Add package release note in tmt try
6610954
Change option name package to install in tmt try
13b4c01
Add mention of prepare/install plugin in tmt try release notes and do…
baa4ff7 
…cumentation
Adjust text length to match the header
2725e5e
Fix links to plugins (#3104)
c31193d
Fix versionadded to current one
f663cde
Move tmt try install release note to 1.37
e07fc57
@falconizmi @happz
Add new line before release note
880c1b3 
Co-authored-by: Miloš Prchlík <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happz happz happz requested changes

@psss psss Awaiting requested review from psss psss is a code owner

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
ci | full test Pull request is ready for the full test execution command | try tmt try command step | prepare Stuff related to the prepare step
Projects
None yet
Milestone
1.37
Development

Successfully merging this pull request may close these issues.
4 participants
@falconizmi @lukaszachy @happz @psss