Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the current directory as anchor_path if there is no fmf_root #3212

Merged
merged 11 commits into from
Nov 4, 2024
Merged

Use the current directory as anchor_path if there is no fmf_root #3212

merged 11 commits into from
Nov 4, 2024

Conversation

falconizmi
Copy link
Collaborator

@falconizmi falconizmi commented Sep 12, 2024 •
edited
Loading

Pull Request Checklist

  • implement the feature

@falconizmi falconizmi self-assigned this Sep 12, 2024
@falconizmi falconizmi added the code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. label Sep 12, 2024
@falconizmi falconizmi added this to the 1.37 milestone Sep 12, 2024
happz
happz reviewed Sep 12, 2024
View reviewed changes
tmt/steps/prepare/ansible.py Outdated Show resolved Hide resolved
@falconizmi falconizmi removed the code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. label Sep 17, 2024
happz
happz reviewed Sep 24, 2024
View reviewed changes
tmt/base.py Outdated Show resolved Hide resolved
@thrix thrix modified the milestones: 1.37, 1.38 Oct 1, 2024
@falconizmi falconizmi force-pushed the iquwarah-tmt-ansible-fmf-root branch 2 times, most recently from abab77c to 3cab1ef Compare October 8, 2024 11:03
@falconizmi falconizmi added the ci | full test Pull request is ready for the full test execution label Oct 8, 2024
@falconizmi falconizmi requested a review from happz October 8, 2024 11:32
happz
happz reviewed Oct 22, 2024
View reviewed changes
tmt/steps/prepare/ansible.py Outdated Show resolved Hide resolved
happz
happz reviewed Oct 22, 2024
View reviewed changes
tmt/base.py Outdated Show resolved Hide resolved
@happz happz mentioned this pull request Oct 23, 2024
Merged
3 tasks
@thrix thrix modified the milestones: 1.38, 1.39 Oct 25, 2024
happz
happz reviewed Oct 31, 2024
View reviewed changes
tmt/base.py Outdated Show resolved Hide resolved
@psss psss requested a review from happz November 1, 2024 16:19
@psss psss force-pushed the iquwarah-tmt-ansible-fmf-root branch from 0dcd8dc to ba39b47 Compare November 1, 2024 16:36
@psss psss added the code | base Base classes implementation in base.py label Nov 1, 2024
psss
psss requested changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. Looks good, just one comment. I've also pushed some minor changes in ba39b47.

tmt/utils/git.py Outdated Show resolved Hide resolved
@psss psss changed the title Return error message when no fmf root found in ansible prepare Use the current directory as anchor_path if there is no fmf_root Nov 1, 2024
@psss psss force-pushed the iquwarah-tmt-ansible-fmf-root branch from 6f41bc7 to 677cd8a Compare November 2, 2024 15:30
@psss
Copy link
Collaborator

psss commented Nov 4, 2024

Just stuck fedora-41 jobs, full plan passed, merging.

@psss psss merged commit af76557 into main Nov 4, 2024
18 of 22 checks passed
@psss psss deleted the iquwarah-tmt-ansible-fmf-root branch November 4, 2024 07:41
@psss psss assigned psss and unassigned falconizmi Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therazix therazix therazix approved these changes

@psss psss psss approved these changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

@happz happz Awaiting requested review from happz happz is a code owner

Assignees

@psss psss

Labels
ci | full test Pull request is ready for the full test execution code | base Base classes implementation in base.py
Projects
None yet
Milestone
1.39
Development

Successfully merging this pull request may close these issues.
6 participants
@falconizmi @psss @happz @lukaszachy @therazix @thrix